On 21/02/24 08:42, Guenter Roeck wrote: > On 2/19/24 14:18, Chris Packham wrote: >> From: Ibrahim Tilki <Ibrahim.Tilki@xxxxxxxxxx> >> >> Adding support for Analog Devices MAX313XX series RTCs. >> > > Adding -> Add > > The subject should really be something like "rtc: max31335: Add support > for additional chips", with details in the patch description. Ack. > All those (in my opinion unnecessary) function, data structure, > and variable renames makes it really difficult to review the code. > I don't see the point of that, so please don't expect any further > feedback about the hwmon changes from me. Sorry about that. In reality what happened is that someone started trying to add support for the range then they left Analog Devices with the patch still in flight. In the mean time someone else from AD landed a driver for a single variant (with no public datasheet). I'm left trying to pick up the pieces. This is effectively the original max313xx series patch with the max31335 changes incorporated as best I can. I can probably rename more things so there is less delta against the max31335 driver. > Thanks, > Guenter >
