On Wed, Feb 14, 2024 at 05:22:35PM PST, Guenter Roeck wrote:
On 2/14/24 17:04, Zev Weiss wrote:
On Wed, Feb 14, 2024 at 11:43:41AM PST, Guenter Roeck wrote:
If a chip only provides a single regulator, it should be named 'vout'
and not 'vout0'. Declare regulator using PMBUS_REGULATOR_ONE() to make
that happen.
Hi Guenter,
This will necessitate a DTS update on at least one platform to maintain compatibility (Delta ahe50dc BMC, [1]). I'm not sure offhand if there are process/policy rules about mixing code changes and device-tree changes in the same commit, but changing either one without the other would break things.
[1] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/arch/arm/boot/dts/aspeed/aspeed-bmc-delta-ahe50dc.dts?id=8d3dea210042f54b952b481838c1e7dfc4ec751d#n21
Sigh. Agreed, especially since changing the dts file in the kernel
won't change the dtb files on actual hardware.
I really have no good solution for this. We (Well, I) didn't realize that
there are regulator naming conventions/restrictions when we introduced
regulator support into PMBus drivers. My bad. Let's see what others say.
Guenter
Well, perhaps mitigating that slightly: I don't see any obvious cases of
any other platforms' device-trees having any dependencies on the
regulator naming that would be affected by this (judging by 'git grep
vout0 arch/*/boot/dts' anyway), and at least with OpenBMC on the ahe50dc
(the primary and AFAIK only user of that device-tree) the dtb would also
be updated along with any kernel update.
So I wouldn't expect it to cause anyone any actual problems if we went
ahead and changed it anyway; as long as the dts & driver do stay in sync
with each other, maybe we could let it slide if it's otherwise a
desirable change to make?
Zev
