Hello again Dan, On 07.02.24 10:51, Dan Carpenter wrote: > Hello Javier Carrasco, > > The patch 33c41faa98f3: "hwmon: Add support for Amphenol ChipCap 2" > from Jan 30, 2024 (linux-next), leads to the following Smatch static > checker warning: > > drivers/hwmon/chipcap2.c:327 cc2_get_reg_val() error: uninitialized symbol 'reg_val'. > drivers/hwmon/chipcap2.c:695 cc2_request_alarm_irqs() error: uninitialized symbol 'ret'. > may I ask you what Smatch configuration/arguments you used to find the first warning? I tried kchecker without arguments (with --sparse nothing was found), and only the second warning is reported: ~/smatch/smatch_scripts/kchecker drivers/hwmon/chipcap2.c CHECK scripts/mod/empty.c CALL scripts/checksyscalls.sh CC drivers/hwmon/chipcap2.o CHECK drivers/hwmon/chipcap2.c drivers/hwmon/chipcap2.c:695 cc2_request_alarm_irqs() error: uninitialized symbol 'ret'. I have checked out the current status of the master branch: 7162b9ec99f71 double_fget: warn about re-using file descriptors And of course, the first bug was not removed from the code. Thanks and best regards, Javier Carrasco
