On Wed, Feb 07, 2024 at 11:08:18AM +0100, Javier Carrasco wrote: > > The ret variable should be initialized to 0 because if no irqs are > defined, the function should not fail i.e. the driver supports that case. > That is probably the reason why I did not notice in my tests. These days everyone has the GCC extension to automatically zero out stack variables so it wouldn't have shown up in testing. It's still technically a bug, but I don't know how many people it would affect in real life (probably a small number). regards, dan carpenter