(resend as plain text, sorry for the noise) On 2/02/24 21:28, Krzysztof Kozlowski wrote: > On 02/02/2024 03:52, Chris Packham wrote: >> From: Ibrahim Tilki<Ibrahim.Tilki@xxxxxxxxxx> >> >> Devicetree binding documentation for Analog Devices MAX313XX RTCs >> >> Signed-off-by: Ibrahim Tilki<Ibrahim.Tilki@xxxxxxxxxx> >> Signed-off-by: Zeynep Arslanbenzer<Zeynep.Arslanbenzer@xxxxxxxxxx> >> Signed-off-by: Chris Packham<chris.packham@xxxxxxxxxxxxxxxxxxx> >> --- > ... > >> + clocks: >> + description: >> + RTC uses this clock for clock input when supplied. Clock has to provide >> + one of these four frequencies - 1Hz, 50Hz, 60Hz or 32.768kHz. >> + maxItems: 1 >> + >> + adi,tc-diode: >> + description: >> + Select the diode configuration for the trickle charger. >> + schottky - Schottky diode in series. >> + standard+schottky - standard diode + Schottky diode in series. >> + enum: [schottky, standard+schottky] >> + >> + trickle-resistor-ohms: >> + description: Selected resistor for trickle charger. >> + enum: [3000, 6000, 11000] > Please remind us and document in commit msg, why this cannot be part of > max31335 binding? Looks exactly the same. That is an incredibly good point. The max31335 binding covers one specific chip. This binding covers more and with that there are a few more properties that the max31335 on it's own doesn't have (e.g. the clock consumer, the ability to have different i2c addresses). Binding wise I could probably roll all of the max31335 into this max313xx binding. Driver wise things are a bit trickier. I've only got access to one of the variants so I am hoping to leverage the work Ibrahim had already done. I could attempt to incorporate max31335 support into the max313xx driver but I wouldn't really be able to test it properly and there is a reasonably high chance of regressing something. >> + >> +required: >> + - compatible >> + - reg > Best regards, > Krzysztof >
