RE: [PATCH] hwmon: Remove I2C_CLASS_HWMON from drivers w/o detect() and address_list

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> -----Original Message-----
> From: Heiner Kallweit <hkallweit1@xxxxxxxxx>
> Sent: Samstag, 27. Januar 2024 16:11
> To: Hennerich, Michael <Michael.Hennerich@xxxxxxxxxx>; Jean Delvare
> <jdelvare@xxxxxxxx>; Guenter Roeck <linux@xxxxxxxxxxxx>
> Cc: linux-hwmon@xxxxxxxxxxxxxxx
> Subject: Re: [PATCH] hwmon: Remove I2C_CLASS_HWMON from drivers w/o
> detect() and address_list
> 
> 
> On 27.01.2024 16:02, Heiner Kallweit wrote:
> > Class-based I2C probing requires detect() and address_list to be set
> > in the I2C client driver, see checks in i2c_detect().
> > It's misleading to declare I2C_CLASS_HWMON support if this
> > precondition isn't met.
> >
> > Signed-off-by: Heiner Kallweit <hkallweit1@xxxxxxxxx>
> > ---
> >  drivers/hwmon/adm1177.c       | 1 -
> >  drivers/hwmon/ds1621.c        | 1 -
> >  drivers/hwmon/ds620.c         | 1 -
> >  drivers/hwmon/ina209.c        | 1 -
> >  drivers/hwmon/ina238.c        | 1 -
> >  drivers/hwmon/max127.c        | 1 -
> >  drivers/hwmon/max31760.c      | 1 -
> >  drivers/hwmon/max31790.c      | 1 -
> >  drivers/hwmon/max31827.c      | 1 -
> >  drivers/hwmon/max6621.c       | 1 -
> >  drivers/hwmon/max6697.c       | 1 -
> >  drivers/hwmon/occ/p8_i2c.c    | 1 -
> >  drivers/hwmon/pmbus/ir36021.c | 1 -
> >  drivers/hwmon/powr1220.c      | 1 -
> >  drivers/hwmon/sbrmi.c         | 1 -
> >  drivers/hwmon/sbtsi_temp.c    | 1 -
> >  drivers/hwmon/w83773g.c       | 1 -
> >  17 files changed, 17 deletions(-)
> >
> 
> It seems MAINTAINERS needs to be updated.
> 
> Daniel Matyas (daniel.matyas@xxxxxxxxxx) The email address you entered
> couldn't be found. Please check the recipient's email address and try to
> resend the message. If the problem continues, please contact your email
> admin.
> 
> Ibrahim Tilki (Ibrahim.Tilki@xxxxxxxxxx) The email address you entered
> couldn't be found. Please check the recipient's email address and try to
> resend the message. If the problem continues, please contact your email
> admin.

Right - thanks for pointing out.
We'll send a MAINTAINERS patch shortly.

-Michael





[Index of Archives]     [LM Sensors]     [Linux Sound]     [ALSA Users]     [ALSA Devel]     [Linux Audio Users]     [Linux Media]     [Kernel]     [Gimp]     [Yosemite News]     [Linux Media]

  Powered by Linux