On Tue, Jan 23, 2024 at 11:05:26PM +0800, Peng Fan (OSS) wrote: > From: Peng Fan <peng.fan@xxxxxxx> > hwmon: scmi-hwmon: implement change_mode The above subject gives me no clue as what this change wants to achieve. At minimum you need to mention thermal zones as HWMON supports more than just thermal sensors and change mode mentioned in $subject applies to only thermal zones. > The sensor maybe disabled before kernel boot, so add change_mode > to support configuring the sensor to enabled state. > Again above applies to thermal zones only in this patch. It doesn't cover non-thermal sensors, so prefer if you refer it as thermal zones instead of sensors. The change itself looks good. I will ack once you fix the subject and description so that Guenter can pick up the change. -- Regards, Sudeep
