On Sat, Dec 23, 2023 at 04:36:58PM +0900, Seiji Nishikawa wrote:
> This patch, in addition to 95d88d054ad9 that added Dell Precision 7510 to fan
> control whitelist, also adds Precision 7540 to the whitelist, which allows manual
Use imperative mood to describe your patch.
> PWM control on Dell Precision 7540. It has been confirmed that the same SMM
> commands work to enable/disable manual PWM control on Dell Precision 7540.
> Acked-by: Pali Rohár <pali@xxxxxxxxxx>
> ---
> drivers/hwmon/dell-smm-hwmon.c | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/drivers/hwmon/dell-smm-hwmon.c b/drivers/hwmon/dell-smm-hwmon.c
> index 44aaf9b9191d..f946257f72c6 100644
> --- a/drivers/hwmon/dell-smm-hwmon.c
> +++ b/drivers/hwmon/dell-smm-hwmon.c
> @@ -1330,6 +1330,14 @@ static const struct dmi_system_id i8k_whitelist_fan_control[] __initconst = {
> },
> .driver_data = (void *)&i8k_fan_control_data[I8K_FAN_34A3_35A3],
> },
> + {
> + .ident = "Dell Precision 7540",
> + .matches = {
> + DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
> + DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "Precision 7540"),
> + },
> + .driver_data = (void *)&i8k_fan_control_data[I8K_FAN_34A3_35A3],
> + },
> {
> .ident = "Dell XPS 13 7390",
> .matches = {
Patch uses spaces instead of tabs and produces lots of checkpatch warnings
and errors. Also, Signed-off: tag is missing.
Overall, please read and follow Documentation/process/submitting-patches.rst.
Guenter
