Hi Rob, On Tue, Dec 19, 2023 at 5:22 PM Rob Herring <robh@xxxxxxxxxx> wrote: > > > On Tue, 19 Dec 2023 16:00:20 +0800, baneric926@xxxxxxxxx wrote: > > From: Ban Feng <kcfeng0@xxxxxxxxxxx> > > > > Adding bindings for the Nuvoton NCT7363Y Fan Controller > > > > Signed-off-by: Ban Feng <kcfeng0@xxxxxxxxxxx> > > --- > > .../bindings/hwmon/nuvoton,nct7363.yaml | 62 +++++++++++++++++++ > > MAINTAINERS | 6 ++ > > 2 files changed, 68 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/hwmon/nuvoton,nct7363.yaml > > > > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' > on your patch (DT_CHECKER_FLAGS is new in v5.13): Our design is based on [1], and adds fan-common.yaml to Documentation/devicetree/bindings/hwmon/, I didn't see any errors when executing dt_binding_check. This design is suggested by reviewer, and [1] is still reviewing: [1]: https://patchwork.kernel.org/project/linux-hwmon/patch/20231107105025.1480561-2-billy_tsai@xxxxxxxxxxxxxx/ How to modify our patch to achieve referencing patch not merged yet? > > yamllint warnings/errors: > > dtschema/dtc warnings/errors: > /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/hwmon/nuvoton,nct7363.yaml: > Error in referenced schema matching $id: http://devicetree.org/schemas/hwmon/fan-common.yaml > /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/hwmon/nuvoton,nct7363.example.dtb: hwmon@22: fan-0: False schema does not allow {'pwms': [[1, 0, 50000]], 'tach-ch': ['']} > from schema $id: http://devicetree.org/schemas/hwmon/nuvoton,nct7363.yaml# > /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/hwmon/nuvoton,nct7363.example.dtb: hwmon@22: fan-1: False schema does not allow {'pwms': [[1, 1, 50000]], 'tach-ch': b'\x01'} > from schema $id: http://devicetree.org/schemas/hwmon/nuvoton,nct7363.yaml# > /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/hwmon/nuvoton,nct7363.example.dtb: fan-1: tach-ch: b'\x01' is not of type 'object', 'array', 'boolean', 'null' > from schema $id: http://devicetree.org/schemas/dt-core.yaml# > > doc reference errors (make refcheckdocs): > Warning: MAINTAINERS references a file that doesn't exist: Documentation/devicetree/bindings/hwmon/nuvoton,nct736x.yaml > MAINTAINERS: Documentation/devicetree/bindings/hwmon/nuvoton,nct736x.yaml I will modify this typo in v3. Thanks, Ban > > See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20231219080021.2048889-2-kcfeng0@xxxxxxxxxxx > > The base for the series is generally the latest rc1. A different dependency > should be noted in *this* patch. > > If you already ran 'make dt_binding_check' and didn't see the above > error(s), then make sure 'yamllint' is installed and dt-schema is up to > date: > > pip3 install dtschema --upgrade > > Please check and re-submit after running the above command yourself. Note > that DT_SCHEMA_FILES can be set to your schema file to speed up checking > your schema. However, it must be unset to test all examples with your schema. >
