On Sun, Dec 17, 2023 at 11:33 PM Guenter Roeck <linux@xxxxxxxxxxxx> wrote: > > On Tue, Dec 12, 2023 at 12:05:19AM +0800, Potin Lai wrote: > > From: Peter Yin <peteryin.openbmc@xxxxxxxxx> > > > > Add support for mp2856/mp2857 device from Monolithic Power Systems, Inc. > > (MPS) vendor. This is a dual-loop, digital, multi-phase, > > modulation controller. > > > > Signed-off-by: Peter Yin <peteryin.openbmc@xxxxxxxxx> > > Signed-off-by: Potin Lai <potin.lai.pt@xxxxxxxxx> > > Applied, with reservations (because due to lack of datasheet it is all but > impossible to validate the code) and several fixups. So this driver comes > with even less warranty than usual. > > CHECK: Alignment should match open parenthesis > #671: FILE: drivers/hwmon/pmbus/mp2856.c:413: > + memcpy(data->max_phases, mp2856_max_phases[data->chip_id], > + sizeof(data->max_phases)); > > CHECK: Please don't use multiple blank lines > #673: FILE: drivers/hwmon/pmbus/mp2856.c:415: > + > + > > CHECK: Please don't use multiple blank lines > #707: FILE: drivers/hwmon/pmbus/mp2856.c:449: > + > + > > Fix those, and use i2c_get_match_data(). > > _Please_ run your patches through checkpatch. The above is really > completely unnecessary and creates unnecessary extra work for others (me). > > Guenter Apologies for missing the style check issue, I will add "--strict" when running checkpatch.pl in future. And thank you for fixing the mistakes and applying the driver. Potin
