On Thu, Nov 30, 2023 at 08:10:12PM -0800, Guenter Roeck wrote: > On Tue, Nov 28, 2023 at 08:06:03PM +0200, Andy Shevchenko wrote: > > Common pattern of handling deferred probe can be simplified with > > dev_err_probe(). Less code and also it prints the error value. ... > > + if (IS_ERR(data->regmap)) > > + return dev_err_probe(dev, PTR_ERR(data->regmap), "failed to allocate register map\n"); > > That line length was getting too long. Please consider running checkpatch > on your patches. I got your point, but checkpatch has no limit for the string literals, see f4c014c0dede ("checkpatch: allow printk strings to exceed 80 characters to maintain their searchability") ca56dc098caf ("checkpatch: check for quoted strings broken across lines") So, what the exact parameters should I supply to it? -- With Best Regards, Andy Shevchenko