Re: [PATCH v2 1/2] dt-bindings: hwmon: Add LTC4282 bindings

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Nov 27, 2023 at 08:56:36AM +0100, Nuno Sá wrote:
> On Sat, 2023-11-25 at 11:56 +0000, Conor Dooley wrote:
> > On Fri, Nov 24, 2023 at 03:18:16PM +0100, Nuno Sa via B4 Relay wrote:
> > 
> > > +  adi,gpio1-mode:
> > > +    description: Defines the function of the Pin.
> > > +    $ref: /schemas/types.yaml#/definitions/string
> > > +    enum: [gpio, power_bad, power_good]
> > > +
> > > +  adi,gpio2-mode:
> > > +    description: Defines the function of the Pin.
> > > +          0 - GPIO Mode.
> > > +          1 - Acts as an input pin and it is feeded into the ADC.
> > > +          2 - Pulls Low when the MOSFET is dissipating power (stress).
> > 
> > These three descriptions here probably need to be updated, one for being
> > too short and these two for still having the integer stuff in the
> > descriptions. Otherwise I think this is looking okay.
> > 
> 
> Yeah, the integer stuff are leftovers. I can also try to add more into the
> description.

That'd be great, thanks.

Attachment: signature.asc
Description: PGP signature


[Index of Archives]     [LM Sensors]     [Linux Sound]     [ALSA Users]     [ALSA Devel]     [Linux Audio Users]     [Linux Media]     [Kernel]     [Gimp]     [Yosemite News]     [Linux Media]

  Powered by Linux