On Sat, Nov 04, 2023 at 09:29:43AM -0700, Guenter Roeck wrote:
> On 11/4/23 09:07, James Seo wrote:
>>
>> #define HP_WMI_WSTR_INFO(name, wids) { \
>> .matches = { \
>> DMI_EXACT_MATCH(DMI_BOARD_VENDOR, "Hewlett-Packard"), \
>> DMI_EXACT_MATCH(DMI_BOARD_NAME, (name)), \
>> }, \
>> .driver_data = (void *)(wids), \
>> }
>>
>
> Quite frankly, I dislike multi-line macros because they make it (more)
> difficult to understand the code. If that is where you want to go,
> I'd rather keep the current code (or wait until someone else maintains
> the hwmon subsystem).
OK, I'll remove that macro if I end up using a DMI table for this.
>> Out of curiosity, how would you feel about just adding full raw WMI string
>> support now? It wouldn't take much more work and for various small reasons
>> it's starting to look like a better idea to me.
>>
>
> I don't know; I would have to see the code.
I'll submit something in a bit.
