On 31/10/2023 16:28:07+0000, Miclaus, Antoniu wrote: > > According to the register map above, the chip does support > > low and high temperature limits as well as over- and undertemperature > > alarms and interrupts. I would suggest to add support for all of those. > > You might also consider adding support for temperature alarm interrupts > > and report temperature alarm events by calling hwmon_notify_event() > > if a thermal event occurs. > > I've sent in the first version of this patch series a cover letter: > > "Although the datasheet is not public yet, the driver can be made public (on > other linux custom trees it is already). > > The driver was tested with actual hardware and works. > Did you run rtctest? Please provide the output. > Even though the datasheet is not available, if there are any queries about > the functionality of the part, these can be provided/inserted as code comments > inside the driver." > > The reason why I am rushing this a bit is because the customer that uses the > driver wants the driver released and mainline kernel compliant. > > This is an initial version of the driver covering the main use cases (which were > requested, therefore actually used). > > Additional features can be added afterwards, if requested. > > > > > > + > > > + hwmon = devm_hwmon_device_register_with_info(&client->dev, > > client->name, > > > + max31335, > > > + &max31335_chip_info, > > > + NULL); > > > > There is no "depends on HWMON" in the Kconfig entry, meaning this will fail > > to compile if HWMON=n or if HWMON=m and RTC_DRV_MAX31335=y. > > > > Will do in v4. > > > Guenter -- Alexandre Belloni, co-owner and COO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com
