On Tue, Oct 31, 2023 at 09:57:28PM -0700, Guenter Roeck wrote: > On 10/31/23 19:27, Patrick Williams wrote: > > On Tue, Oct 31, 2023 at 04:01:10PM -0700, Guenter Roeck wrote: > >> On Tue, Oct 31, 2023 at 04:58:06PM +0800, Delphine CC Chiu wrote: > >>> Add support for EMC1442 which is compatible with EMC1403. > >>> > >> > >> Unfortunately, almost no information is available about this chip > >> except that it ships in an 8-pin package. Are you sure the chip > >> supports two external temperature sensors like EMC1403 ? > >> The chip numbering and the number of pins would suggest that > >> it only supports a single external temperature sensor, > >> which would make it compatible to emc1402/emc1422. > >> > >> Guenter > > > > The datasheet I've seen says: > > > >>> The EMC1442 monitors two temperature channels (one > >>> external and one internal). > > > > Based on this, I agree that emc1403 seems wrong. The datasheet also > > says: > > > >>> Pin compatible with EMC1412 > > > >> > >>> Signed-off-by: Delphine CC Chiu <Delphine_CC_Chiu@xxxxxxxxxx> > >>> --- > >>> { "emc1422", emc1402 }, > >>> { "emc1423", emc1403 }, > >>> { "emc1424", emc1404 }, > >>> + { "emc1442", emc1403 }, > > > > So, emc1402? > > > > At the very least, if you are willing to confirm that formally > if/when v2 is submitted. Yes, I will confirm from the copy of the datasheet I have available when v2 comes up. > I previously rejected a similar patch adding emc1444 because it was > impossible to get a datasheet to confirm that the chips are really > register compatible. No idea why that has to be so secretive. It is a > temperature sensor, for heaven's sake :-( Delphine, could you reach out to the chip vendor and find out if they are willing to publish a datasheet for this chip? They might not have updated their website yet because EMC1442 shows up on Microchip's site but it has almost no information. -- Patrick Williams
Attachment:
signature.asc
Description: PGP signature