On Wed, 2023-10-25 at 11:57 -0700, Guenter Roeck wrote:
> On Wed, Oct 25, 2023 at 03:21:00PM +0200, Nuno Sa wrote:
> > From: Dragos Bogdan <dragos.bogdan@xxxxxxxxxx>
> >
> > axi_fan_control_irq_handler(), dependent on the private
> > axi_fan_control_data structure, might be called before the hwmon
> > device is registered. That will cause an "Unable to handle kernel
> > NULL pointer dereference" error.
> >
>
> Applied, but, please,
>
> > Fixes: 8412b41 ("hwmon: Support ADI Fan Control IP")
>
> WARNING: Please use correct Fixes: style 'Fixes: <12 chars of sha1> ("<title
> line>")' - ie: 'Fixes: 8412b410fa5e ("hwmon: Support ADI Fan Control IP")'
> #88:
> Fixes: 8412b41 ("hwmon: Support ADI Fan Control IP")
>
> consider running checkpatch on your patches in the future.
>
Oh, sorry for that. As you figured I just cherry-picked the patch from a colleague. I
think it's time to have some kind of hook running some basic checks before git send-
mail.
- Nuno Sá
