On Fri, Oct 20, 2023 at 02:17:25PM +0530, Raag Jadav wrote: > Introduce acpi_dev_uid_match() helper that matches the device with > supplied _UID string. ... > +/** > + * acpi_dev_uid_match - Match device by supplied UID > + * @adev: ACPI device to match. > + * @uid2: Unique ID of the device, pass NULL to not check _UID. > + * > + * Matches UID in @adev with given @uid2. Absence of @uid2 will be treated as > + * a match. If user wants to validate @uid2, it should be done before calling > + * this function. This behaviour is as needed by most of its current users. The "current" internally I applied to the result of the series. So reading this again I think the better wording is "potential". > + * > + * Returns: > + * - %true if matches or @uid2 is NULL. > + * - %false otherwise. > + */ ... > /** > * acpi_dev_hid_uid_match - Match device by supplied HID and UID > * @adev: ACPI device to match. > * @hid2: Hardware ID of the device. > * @uid2: Unique ID of the device, pass NULL to not check _UID. > * > - * Matches HID and UID in @adev with given @hid2 and @uid2. > - * Returns true if matches. > + * Matches HID and UID in @adev with given @hid2 and @uid2. Absence of @uid2 > + * will be treated as a match. If user wants to validate @uid2, it should be > + * done before calling this function. This behaviour is as needed by most of > + * its current users. Ditto. > + * Returns: > + * - %true if matches or @uid2 is NULL. > + * - %false otherwise. > */ -- With Best Regards, Andy Shevchenko
