On Fri, Oct 06, 2023 at 05:44:52PM -0500, Rob Herring wrote:
> Use preferred i2c_get_match_data() instead of of_match_device() and
> i2c_match_id() to get the driver match data. With this, adjust the
> includes to explicitly include the correct headers.
>
> Signed-off-by: Rob Herring <robh@xxxxxxxxxx>
> ---
> drivers/hwmon/max6650.c | 8 +++-----
> drivers/hwmon/nct6775-i2c.c | 14 ++------------
> drivers/hwmon/nct6775.h | 2 +-
> drivers/hwmon/pmbus/lm25066.c | 14 +++-----------
I would very much prefer one patch per driver.
[ ... ]
> +enum kinds { nct6106 = 1, nct6116, nct6775, nct6776, nct6779, nct6791, nct6792,
> nct6793, nct6795, nct6796, nct6797, nct6798, nct6799 };
Each of those instances needs to include a comment exlaining why the first
id now needs to start with 1.
Guenter
