Hi Badal, On Mon, Sep 25, 2023 at 01:48:38PM +0530, Badal Nilawar wrote: > Expose Card reactive sustained (pl1) power limit as power_max and > card default power limit (tdp) as power_rated_max. > > v2: > - Fix review comments (Riana) > v3: > - Use drmm_mutex_init (Matt Brost) > - Print error value (Matt Brost) > - Convert enums to uppercase (Matt Brost) > - Avoid extra reg read in hwmon_is_visible function (Riana) > - Use xe_device_assert_mem_access when applicable (Matt Brost) > - Add intel-xe@xxxxxxxxxxxxxxxxxxxxx in Documentation (Matt Brost) > v4: > - Use prefix xe_hwmon prefix for all functions (Matt Brost/Andi) > - %s/hwmon_reg/xe_hwmon_reg (Andi) > - Fix review comments (Guenter/Andi) > v5: > - Fix review comments (Riana) > v6: > - Use drm_warn in default case (Rodrigo) > - s/ENODEV/EOPNOTSUPP (Andi) > > Acked-by: Rodrigo Vivi <rodrigo.vivi@xxxxxxxxx> > Reviewed-by: Riana Tauro <riana.tauro@xxxxxxxxx> > Signed-off-by: Badal Nilawar <badal.nilawar@xxxxxxxxx> looks good to me: Reviewed-by: Andi Shyti <andi.shyti@xxxxxxxxxxxxxxx> Andi