On 2023-09-18 12:05:19-0700, Guenter Roeck wrote: > On Mon, Sep 11, 2023 at 07:44:42AM +0200, Thomas Weißschuh wrote: > > The KM002C is similar to the KM003C and seems to use the same > > protocol and firmware. > > > > Reported-by: Douglas Gilbert <dgilbert@xxxxxxxxxxxx> > > Closes: https://lore.kernel.org/lkml/290ebce4-54f0-8ac1-2a13-cbc806d80d64@xxxxxxxxxxxx/ > > Signed-off-by: Thomas Weißschuh <linux@xxxxxxxxxxxxxx> > > --- > > > > This patch is based on hwmon-next, > > commit 80369d9e1f2f ("hwmon: (sch5627) Document behaviour of limit registers"). > > > > Signed-off-by: Thomas Weißschuh <linux@xxxxxxxxxxxxxx> > > Applied, but please be more careful with your comments and Signed-off-by: > tags. There should only be one '---', and one signature. Thanks, the duplicate Signed-off-by is indeed an oversight which I'll try to avoid in the future. As for the '---': Two of them are generated by the 'b4' tool and I added one manually with the hwmon-next information. For other subsystems this wasn't an issue so far. Are these duplicate sections a problem for your personal tooling or is it affecting something more widespread? I can try to avoid these issues when sending patches to you specifically or maybe changes in b4 in general are the correct solution. Thomas > > --- > > drivers/hwmon/powerz.c | 1 + > > 1 file changed, 1 insertion(+) > > > > > > --- > > base-commit: 80369d9e1f2f16993ae6d148553c37bf65a209e4 > > change-id: 20230911-powerz-km002c-94afb4d3d645 > > > > Best regards, > > > > diff --git a/drivers/hwmon/powerz.c b/drivers/hwmon/powerz.c > > index 2b9693aee6f6..cfb635f94d66 100644 > > --- a/drivers/hwmon/powerz.c > > +++ b/drivers/hwmon/powerz.c > > @@ -254,6 +254,7 @@ static void powerz_disconnect(struct usb_interface *intf) > > } > > > > static const struct usb_device_id powerz_id_table[] = { > > + { USB_DEVICE_INTERFACE_NUMBER(0x5FC9, 0x0061, 0x00) }, /* ChargerLAB POWER-Z KM002C */ > > { USB_DEVICE_INTERFACE_NUMBER(0x5FC9, 0x0063, 0x00) }, /* ChargerLAB POWER-Z KM003C */ > > { } > > };
