Re: hwmon: (nct6775) Regression Bisected

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 9/16/23 10:45, Ahmad Khalifa wrote:
On 16/09/2023 18:04, Guenter Roeck wrote:

The proper fix should really be in nct6775_in_is_visible(),
which should drop the attribute if there is no alarm bit for it,
similar to, for example, nct6775_fan_is_visible().
Something like

     int nr = index % 5;     /* attribute index */

     if (nr == 1 && data->ALARM_BITS[in] == -1)
                 return 0;

Perfect, that's what I looked for but couldn't figure it out in
a rush. If it's confirmed, I'll convert the fix so it hides the
attribute instead.


I'd suggest to just send a patch. We can always update it with v2
if a revision is needed.

Thanks,
Guenter




[Index of Archives]     [LM Sensors]     [Linux Sound]     [ALSA Users]     [ALSA Devel]     [Linux Audio Users]     [Linux Media]     [Kernel]     [Gimp]     [Yosemite News]     [Linux Media]

  Powered by Linux