Re: [PATCH 2/3] dt-bindings: regulator: Add mps,mpq2286 power-management IC

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 11/09/23 11:56, Krzysztof Kozlowski wrote:
On 11/09/2023 05:41, Saravanan Sekar wrote:
Document mpq2286 power-management IC

Signed-off-by: Saravanan Sekar <saravanan@xxxxxxxxxxx>

Please use subject prefixes matching the subsystem. You can get them for
example with `git log --oneline -- DIRECTORY_OR_FILE` on the directory
your patch is touching. It's: regulator: dt-bindings:

Thanks for your time to review. git log has mix of "regulator: dt-bindings" and "dt-bindings: regualtor". I had referred my own accepted driver regulator/mps,mpq7932.yaml


---
  .../bindings/regulator/mps,mpq2286.yaml       | 59 +++++++++++++++++++
  1 file changed, 59 insertions(+)
  create mode 100644 Documentation/devicetree/bindings/regulator/mps,mpq2286.yaml

diff --git a/Documentation/devicetree/bindings/regulator/mps,mpq2286.yaml b/Documentation/devicetree/bindings/regulator/mps,mpq2286.yaml
new file mode 100644
index 000000000000..d00d887870a9
--- /dev/null
+++ b/Documentation/devicetree/bindings/regulator/mps,mpq2286.yaml
@@ -0,0 +1,59 @@
+# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/regulator/mps,mpq2286.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Monolithic Power System MPQ2286 PMIC
+
+maintainers:
+  - Saravanan Sekar <saravanan@xxxxxxxxxxx>
+
+properties:
+  compatible:
+    enum:
+      - mps,mpq2286
+
+  reg:
+    maxItems: 1
+
+  regulators:
+    type: object
+
+    properties:
+      "buck0":

You did not test it... Sigh. Anyway, there is no need for entire
regulators node for one regulator. Can the device do anything else than
being a regulator?


I tested it, but documentation is not updated with test findings (buck0).

Other chipset has multiple regulator so dts has regulators node to keep the driver common

Primarily device is a regulator with pmbus capability like fault status (OV,OC, VIN, VOUT, Power good status), temperature status.

Best regards,
Krzysztof

Thanks,
Saravanan





[Index of Archives]     [LM Sensors]     [Linux Sound]     [ALSA Users]     [ALSA Devel]     [Linux Audio Users]     [Linux Media]     [Kernel]     [Gimp]     [Yosemite News]     [Linux Media]

  Powered by Linux