On Fri, Aug 25, 2023 at 08:01:49AM +0000, Biju Das wrote: > > > > > > You mean split this into 2. First patch with just this logic (channel > > > >= data->max_channels) and keep data->id in remaining Places and Second > > patch is to replace the id and use max_channels instead. > > > > > > > There is only one field available in struct i2c_device_id. > > Splitting this patch in 2 seems overkill because the first patch would have > > to introduce code (set max_channels based on enum tmp51x_ids) only to > > remove it in the second patch. > > The plan was, > > First patch will replace id->max_channels in the table > and will fill the id based on max_channels and fix the logic for invalid channels. > > The Second patch is to remove id altogether. > > I am ok with doing it in the same patch. Please let me know. > Same here. You can try with your two-step approach, but please do not introduce code in step 1 only to remove it in step 2. Thanks, Guenter
