On Wed, Aug 16, 2023 at 11:28:07PM -0700, Michael Chan wrote: > On Wed, Aug 16, 2023 at 12:25 PM Guenter Roeck <linux@xxxxxxxxxxxx> wrote: > > > > On Wed, Aug 16, 2023 at 09:42:17PM +0530, Kalesh Anakkur Purayil wrote: > > > [Kalesh]: Sorry, I don't quite get this part. I was looking at the kernel > > > hwmon code, but could not find any reference. > > > > > > > It would be non-standard attributes, so, correct, there is no reference. > > > > > Can we add new attributes "shutdown" and "shutdown_alarm" for tempX? For > > > example: > > > > > > #define HWMON_T_SHUTDOWN BIT(hwmon_temp_shutdown) > > > > > > > Not for a single driver. You can implement the sysfs attributes > > directly in the driver and pass an extra attribute group to the > > hwmon core when registering the hwmon device. > > Thanks for the review. I will drop these hwmon patches for now and > respin the others for v2. Kalesh will rework these hwmon patches. Alternatively you could keep the standard attributes and add the shutdown attributes later. Guenter
