On 08/08/2023 09:54, Mathew McBride wrote: > Hi Krzysztof, > > On Tue, Aug 8, 2023, at 5:38 PM, Krzysztof Kozlowski wrote: >> On 08/08/2023 03:31, Mark Tomlinson wrote: >>> This patch adds a HWMON driver for the EMC1812, EMC1813, EMC1814, >>> EMC1815 and EMC1833 temperature sensor chips from microchip. Does not >>> currently support the alert outputs. >>> >>> Signed-off-by: Mark Tomlinson <mark.tomlinson@xxxxxxxxxxxxxxxxxxx> >>> Co-developed-by: Mathew McBride <matt@xxxxxxxxxxxxxxx> >>> Signed-off-by: Mathew McBride <matt@xxxxxxxxxxxxxxx> >> >> The order of these tags is clearly not correct. It says Mathew is >> sending, but you are not Mathew? > > Just to clarify, Mark has developed this version based off something I wrote a while ago: > > https://gitlab.com/traversetech/ls1088firmware/traverse-sensors/-/blob/master/emc181x/emc181x.c?ref_type=heads > > Hence my copyright is listed in the header. > > I advised him to list the authors in that order following the example in the kernel's "submitting patches" guide [2] which provides an example of such a situation: > > https://docs.kernel.org/process/submitting-patches.html#when-to-use-acked-by-cc-and-co-developed-by The last entry is: Signed-off-by: From Author <from@xxxxxxxxxxxxxxxxxx> So it is expected to be Mark. Best regards, Krzysztof
