On 03-08-2023 05:02, Andi Shyti wrote:
Hi Badal,
[...]
HWMON_CHANNEL_INFO(power, HWMON_P_MAX | HWMON_P_RATED_MAX | HWMON_P_CRIT),
HWMON_CHANNEL_INFO(curr, HWMON_C_CRIT),
+ HWMON_CHANNEL_INFO(in, HWMON_I_INPUT),
NULL
};
@@ -244,6 +254,18 @@ static int hwmon_pcode_write_i1(struct xe_gt *gt, u32 uval)
uval);
}
+static int hwmon_get_voltage(struct xe_hwmon_data *ddat, long *value)
one thing I forgot to mention also in previous patches is that
hwmon_* and HWMON_* as prefixes do not belong to the xe driver.
Yes, that's why in previous series we were using hwm_* prefix for static
functions. I think I will use xe_hwmon* for static as well as global.
Regards,
Badal
You should use an xe related prefix, like xe_hwmon.
Rest looks good,
Andi
