Re: [PATCH v3 1/6] drm/xe/hwmon: Add HWMON infrastructure

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 8/2/23 16:34, Andi Shyti wrote:
Hi Guenter,

[...]

+static const struct hwmon_channel_info *hwmon_info[] = {
+	NULL
+};

just:

    static const struct hwmon_channel_info *hwmon_info[] = { };

would do.


What would be the point ? This is just a placeholder, and we need
a NULL entry at the end.

right... this series needs to be read from the end to the
beginning :)


Or applied completely, review the result, and then dig back to
the individual patches to provide feedback. I got severely confused
when trying to review the series. I am not really sure if the split
into multiple patches is really making the review easier; it seems
to me it does the opposite.

Guenter




[Index of Archives]     [LM Sensors]     [Linux Sound]     [ALSA Users]     [ALSA Devel]     [Linux Audio Users]     [Linux Media]     [Kernel]     [Gimp]     [Yosemite News]     [Linux Media]

  Powered by Linux