On Wed, Aug 02, 2023 at 09:30:23AM +0200, Carsten Spieß wrote: > > On 8/1/23 22:52, Conor Dooley wrote: > > On Tue, Aug 01, 2023 at 06:35:46PM +0200, Carsten Spieß wrote: > > > Add dt-bindings for Renesas ISL28022 power monitor. > > > +properties: > > > + compatible: > > > + enum: > > > + - renesas,isl28022 > > > > You've only got one compatible, why the enum? Will there be more similar > > devices that have an incompatible programming model? > Yes, there are isl28023 and isl28025 with different register addresses, > might be supported in future releases. This is misleading. ISL28023 and ISL28025 are PMBus compatible chips and would be added as PMBus driver(s) (if needed). Support for those chips will never be part of the isl28022 driver, and any devicetree properties of those chips would not be described in this file. Guenter > > > > + renesas,shunt-range-microvolt: > > > + description: | > > > > You don't need these |s if you have no formatting to preserve in the > > text. > Will fix in v4. > > > Otherwise, this does look good to me. > Thanks, regards > Carsten
