On 02/08/2023 15:10, Gal Pressman wrote: > Hi Guenter, > > On 27/07/2023 22:54, Guenter Roeck wrote: >> On 7/27/23 11:59, Saeed Mahameed wrote: >>> From: Adham Faris <afaris@xxxxxxxxxx> >>> $ grep -H -d skip . /sys/class/hwmon/hwmon0/* >>> >>> Output >>> ======================================================================= >>> /sys/class/hwmon/hwmon0/name:0000:08:00.0 >> >> That name doesn't seem to be very useful. You might want to consider >> using a different name, such as a simple "mlx5". Since the parent is >> a pci device, the "sensors" command would translate that into something >> like "mlx5-pci-XXXX" which would be much more useful than the >> "0000:08:00.0-pci-0000" which is what you'll see with the current >> name. >> >>> /sys/class/hwmon/hwmon0/temp1_crit:105000 >>> /sys/class/hwmon/hwmon0/temp1_highest:68000 >>> /sys/class/hwmon/hwmon0/temp1_input:68000 >>> /sys/class/hwmon/hwmon0/temp1_label:sensor0 >> >> I don't really see the value of that label. A label provided by the driver >> should be meaningful and indicate something such as the sensor location. >> Otherwise the default of "temp1" seems to be just as useful to me. > > Agree, will change. Sorry, this reply refers to your previous comment about the name (use "mlx5"). The label used here is meaningful, to clarify, when new firmware is used the label you'll see here is the actual name of the sensor (we'll put it in the commit message). For older firmware versions, the index used is not a simple incrementing counter, it indicates the index of the sensor as defined by our HW spec. Both cases are better than the default label.
