On 7/29/23 06:42, Aleksa Savic wrote:
On 2023-07-29 15:31:12 GMT+02:00, Aleksa Savic wrote:
Add a 200ms delay after sending a ctrl report to Quadro,
Octo, D5 Next and Aquaero to give them enough time to
process the request and save the data to memory. Otherwise,
under heavier userspace loads where multiple sysfs entries
are usually set in quick succession, a new ctrl report could
be requested from the device while it's still processing the
previous one and fail with -EPIPE.
Reported by a user on Github [1] and tested by both of us.
[1] https://github.com/aleksamagicka/aquacomputer_d5next-hwmon/issues/82
Signed-off-by: Aleksa Savic <savicaleksa83@xxxxxxxxx>
---
Changes in v2:
- Added missing <linux/delay.h> include
---
Sorry for the noise, I didn't include the Cc: stable@xxxxxxxxxxxxxxx
line from v1 in v2. Do I need to resend?
Normally it would be me adding that. Instead, it would make much more
sense to add a Fixes: tag, because otherwise I'll have to spend time
figuring that out. Also, you are not supposed to actually send the patch
to the stable@ mailing list because it hasn't been accepted into the
upstream kernel. It is only necessary to actually send a patch to the
stable@ mailing list if it is a backport.
Either case I'd suggest to consider addressing my feedback before sending
yet another version.
Guenter
