On Thu, 27 Jul 2023, Guenter Roeck wrote:
On 7/27/23 09:39, Uwe Kleine-König wrote:
On Thu, Jul 27, 2023 at 06:34:14AM -0700, Guenter Roeck wrote:
On 7/27/23 00:11, Uwe Kleine-König wrote:
The previous mass switch of hwmon drivers done in commit 1975d167869e
("hwmon: Switch i2c drivers back to use .probe()") was based on
v6.4-rc1. Since then this driver was added which needs to be converted
back in the same way before eventually .probe_new() can be dropped from
struct i2c_driver.
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx>
---
Hello,
this driver appeared in next today. It would be great if this patch
could be added on top to not interfere with the quest to remove
.probe_new directly after v6.6-rc1.
I just made the change in the original patch.
fine for me.
Thanks, and sorry for not noticing.
If that helps: this wasn't the first recent commit reintroducing a
.probe_new :-) Actually I wanted to drop .probe_new already in the last
cycle but didn't pay attention between v6.4 and v6.5-rc1 which
introduced a few more of these. In the current cycle this was already
the fifth.
Sorry, I didn't pay attention. I'll try to do better. I may need my own
version of checkpatch ...
Guenter
Hello Uwe, hello Guenter,
maybe it's because I needed to test the driver in Linux 5.10 on my custom
embedded device. I compiled the driver also in the new Kernel, always
rebasing on the latest master but testing its behavior was done in 5.10.
So thats maybe why the deprecated probe_new function pointer was still in the driver.
So also from my side, sorry for the extra effort.
Regards,
Andre
