> -----Original Message----- > From: Guenter Roeck <groeck7@xxxxxxxxx> On Behalf Of Guenter Roeck > Sent: Monday, April 24, 2023 9:50 PM > To: Delphine_CC_Chiu/WYHQ/Wiwynn <Delphine_CC_Chiu@xxxxxxxxxx> > Cc: patrick@xxxxxxxxx; Jean Delvare <jdelvare@xxxxxxxx>; Rob Herring > <robh+dt@xxxxxxxxxx>; Krzysztof Kozlowski > <krzysztof.kozlowski+dt@xxxxxxxxxx>; linux-i2c@xxxxxxxxxxxxxxx; > linux-hwmon@xxxxxxxxxxxxxxx; devicetree@xxxxxxxxxxxxxxx; > linux-kernel@xxxxxxxxxxxxxxx > Subject: Re: [PATCH v1 1/2] dt-bindings: hwmon: Add lltc ltc4286 driver > bindings > > Security Reminder: Please be aware that this email is sent by an external > sender. > > On Mon, Apr 24, 2023 at 06:13:49PM +0800, Delphine CC Chiu wrote: > > Add a device tree bindings for ltc4286 driver. > > > > Signed-off-by: Delphine CC Chiu <Delphine_CC_Chiu@xxxxxxxxxx> > > --- > > .../bindings/hwmon/lltc,ltc4286.yaml | 47 > +++++++++++++++++++ > > MAINTAINERS | 9 ++++ > > 2 files changed, 56 insertions(+) > > create mode 100644 > > Documentation/devicetree/bindings/hwmon/lltc,ltc4286.yaml > > > > diff --git a/Documentation/devicetree/bindings/hwmon/lltc,ltc4286.yaml > > b/Documentation/devicetree/bindings/hwmon/lltc,ltc4286.yaml > > new file mode 100644 > > index 000000000000..c1c8e310f9c4 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/hwmon/lltc,ltc4286.yaml > > @@ -0,0 +1,47 @@ > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) %YAML 1.2 > > +--- > > +$id: > > +https://apc01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fdevi > > > +cetree.org%2Fschemas%2Fhwmon%2Flltc%2Cltc4286.yaml%23&data=05%7C > 01%7C > > > +Wayne_SC_Liu%40wiwynn.com%7Cac3bc6cdf556435cfa0f08db44cabd06%7C > da6e06 > > > +28fc834caf9dd273061cbab167%7C0%7C0%7C638179409777006260%7CUnk > nown%7CT > > > +WFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLC > JXVC > > > +I6Mn0%3D%7C3000%7C%7C%7C&sdata=8d9ycpebE%2FrhafDDmDL9sefo1xq > m%2B9r%2F > > +Wm0Cu1McEOs%3D&reserved=0 > > +$schema: > > +https://apc01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fdevi > > > +cetree.org%2Fmeta-schemas%2Fcore.yaml%23&data=05%7C01%7CWayne_S > C_Liu% > > > +40wiwynn.com%7Cac3bc6cdf556435cfa0f08db44cabd06%7Cda6e0628fc834c > af9dd > > > +273061cbab167%7C0%7C0%7C638179409777006260%7CUnknown%7CTWFp > bGZsb3d8ey > > > +JWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D > %7C30 > > > +00%7C%7C%7C&sdata=u4yJaVeL2xSUE2%2FaNpEbQ3KJiy%2BcxtKG95gGuaGI > LFU%3D& > > +reserved=0 > > + > > +title: LTC4286 power monitors > > + > > +maintainers: > > + - Delphine CC Chiu <Delphine_CC_Chiu@xxxxxxxxxx> > > + > > +properties: > > + compatible: > > + enum: > > + - lltc,ltc4286 > > + - lltc,ltc4287 > > There is no LTC4287, at least according to the Analog website. It has been announced on Analog Devices website. Please refer to this link: https://www.analog.com/en/products/ltc2487.html#product-overview > > > + > > + reg: > > + maxItems: 1 > > + > > + vrange_select_25p6: > > + description: > > + This property is a bool parameter to represent the > > + voltage range is 25.6 or not for this chip. > > Existing attributes are adi,vrange-high-enable, ti,extended-range-enable, > ti,bus-range-microvolt, adi,range-double. I would suggest to use > adi,vrange-high-enable. The vrange for this chip is either 102.4 or 25.6, and default is 102.4 So, we think vrange_select_25p6 may be more appropriate > > > + > > + rsense-micro-ohms: > > + description: > > + Resistor value in micro-Ohm > > I would suggest either shunt-resistor-micro-ohms or > sense-resistor-micro-ohms as used by other bindings. We will revise to shunt-resistor-micro-ohms. > > > + > > +required: > > + - compatible > > + - reg > > + - rsense-micro-ohms > > + > > +additionalProperties: false > > + > > +examples: > > + - | > > + i2c { > > + status = "okay"; > > + ltc4286@40 { > > + compatible = "lltc,ltc4286"; > > + reg = <0x40>; > > + vrange_select_25p6; > > + rsense-micro-ohms = <300>; > > + }; > > + }; > > diff --git a/MAINTAINERS b/MAINTAINERS index > > c6545eb54104..930bdba0f73c 100644 > > --- a/MAINTAINERS > > +++ b/MAINTAINERS > > @@ -12183,6 +12183,15 @@ S: Maintained > > F: Documentation/hwmon/ltc4261.rst > > F: drivers/hwmon/ltc4261.c > > > > +LTC4286 HARDWARE MONITOR DRIVER > > +M: Delphine CC Chiu <Delphine_CC_Chiu@xxxxxxxxxx> > > +L: linux-i2c@xxxxxxxxxxxxxxx > > +S: Maintained > > +F: Documentation/devicetree/bindings/hwmon/lltc,ltc4286.yaml > > +F: drivers/hwmon/pmbus/Kconfig > > +F: drivers/hwmon/pmbus/Makefile > > +F: drivers/hwmon/pmbus/ltc4286.c > > + > > LTC4306 I2C MULTIPLEXER DRIVER > > M: Michael Hennerich <michael.hennerich@xxxxxxxxxx> > > L: linux-i2c@xxxxxxxxxxxxxxx > > -- > > 2.17.1 > >
