Re: [PATCH 1/1] hwmon: nct7802: Fix for temp6 (PECI1) processed even if PECI1 disabled

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Jul 21, 2023 at 07:29:19PM +0200, Gilles BULOZ wrote:
> Because of hex value 0x46 used instead of decimal 46, the temp6
> (PECI1) temperature is always declared visible and then displayed
> even if disabled in the chip
> 
> Signed-off-by: Gilles Buloz <gilles.buloz@xxxxxxxxxxx>

Applied.

In the future, please version your patches and provide change logs.
Also, please fix your e-mail address configuration to avoid the
following checkpatch warning.

From:/Signed-off-by: email name mismatch: 'From: Gilles BULOZ <gilles.buloz@xxxxxxxxxxx>' != 'Signed-off-by: Gilles Buloz <gilles.buloz@xxxxxxxxxxx>'

Thanks,
Guenter

> ---
>   drivers/hwmon/nct7802.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/hwmon/nct7802.c b/drivers/hwmon/nct7802.c
> index 9339bfc..024cff1 100644
> --- a/drivers/hwmon/nct7802.c
> +++ b/drivers/hwmon/nct7802.c
> @@ -725,7 +725,7 @@ static umode_t nct7802_temp_is_visible(struct kobject *kobj,
>   	if (index >= 38 && index < 46 && !(reg & 0x01))		/* PECI 0 */
>   		return 0;
>   
> -	if (index >= 0x46 && (!(reg & 0x02)))			/* PECI 1 */
> +	if (index >= 46 && !(reg & 0x02))			/* PECI 1 */
>   		return 0;
>   
>   	return attr->mode;



[Index of Archives]     [LM Sensors]     [Linux Sound]     [ALSA Users]     [ALSA Devel]     [Linux Audio Users]     [Linux Media]     [Kernel]     [Gimp]     [Yosemite News]     [Linux Media]

  Powered by Linux