> > + > > +/* > > + * When an interrupt fires for a PSU config change > > + * there is a need to know the previous PSU configuration > > + * so that the appropriate gpio line is interrupted for > > + * the correct PSU. In order to keep this variable up to > > + * date it is global so that it can be set at init and > > + * each time the interrupt fires. > > + */ > > +u8 psu_presence; > I'm not buying it. There's no user of this variable outside of this > compilation unit, is there? If there was - the name should have some > prefix but even then, I don't see a need for this to be global. Why > don't you put it in struct gxp_gpio_drvdata? Hi Bart, You are correct this should not be global. It will be placed in gxp_gpio_drvdata. Thank you for catching this and the assistance, -Nick Hawkins
