Re: [PATCH v2] hwmon: (nct6775) Add support for 18 IN readings for nct6799

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 7/19/23 12:41, Ahmad Khalifa wrote:
On 19/07/2023 03:49, Guenter Roeck wrote:
On Tue, Jul 18, 2023 at 07:29:12PM +0100, Ahmad Khalifa wrote:
     * Add separate scaling_in and pass it through data as they were
       missing in v1 and the factors differ with other chips
The scaling change is really a bug fix; it should be a separate patch
marked as Fixes:. It also affects NCT6798D.

Missed checking 6798 voltage, thought it was only temps missing.
But now that I checked, I can see the 17th voltage and it's the
same as 6799.

Not sure if to add that with the 6799 or leave it safely with 15
as it is. Adding it alone, too risky, I can't test that.


Leave it. We can always add it later if/when someone can test it.
The documentation is inconsistent anyway. The summary and chapter 8.1 both
say that there are 16 voltages. Then 8.6.2 suddenly says that there is also
VHIF, and the registers for VHIF are widely listed. We would need someone
to confirm that it actually works.

Thanks,
Guenter




[Index of Archives]     [LM Sensors]     [Linux Sound]     [ALSA Users]     [ALSA Devel]     [Linux Audio Users]     [Linux Media]     [Kernel]     [Gimp]     [Yosemite News]     [Linux Media]

  Powered by Linux