On Mon, Jul 17, 2023 at 07:25:15PM -0300, Joaquín Ignacio Aramendía wrote: > A driver should not be manually adding groups in its probe function (it will > race with userspace), so replace the call to devm_device_add_groups() to use > the platform dev_groups callback instead. > > This will allow for removal of the devm_device_add_groups() function. > > Signed-off-by: Joaquín Ignacio Aramendía <samsagax@xxxxxxxxx> > --- > drivers/hwmon/oxp-sensors.c | 38 +++++++++++++++++++++++-------------- > 1 file changed, 24 insertions(+), 14 deletions(-) Reviewed-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>