On Mon, Jul 17, 2023 at 09:10:51PM +0100, Ahmad Khalifa wrote: > * Increase available bits, IN: 16 to 24, FAN: 8 to 12, > TEMP: 6 to 12 > * Reorder alarm/beep definitions to match in order to allow > additional inputs in the future > * Remove comments about 'unused' bits as probe() is a better > reference > > Testing note: > * Tested on nct6799 with IN/FAN/TEMP, and changing min/max/high/hyst, > that triggers the corresponding alarms correctly. Good confirmation > on the original mapping of the registers and masks. > As to be expected, only 4 fans and 2 temps (fixed) have limits > currently on nct6799 on my board. > * Trouble with testing intrusion alarms and beeps, no way to confirm > those. As I understand now, intrusion/caseopen is probably not > connected on my board. > And I haven't seen a buzzer on a board in ages. > > Signed-off-by: Ahmad Khalifa <ahmad@xxxxxxxxxx> Tested working on nct6797, with no functional differences observed, and the code looks good to me. Applied to hwmon-next. Thanks, Guenter