Re: [PATCH] hwmon: (nct6775) Increase and reorder ALARM/BEEP bits

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 7/17/23 10:39, Ahmad Khalifa wrote:
On 17/07/2023 18:25, Guenter Roeck wrote:
On 7/17/23 09:49, Ahmad Khalifa wrote:
* Increase available bits, IN: 16 to 24, FAN: 8 to 12,
   TEMP: 6 to 12

intrusion: 2 to 4 ? Curious: Why ? It doesn't seem to be used,
and it could easily be extended later if really needed.

Just thought I'd save others having to reorder bits again.
But thinking about it now, never seen a 4-door case.
Having 2 only and beep at 50 means the whole thing likely pads to
52B instead of 56B.

Will update.

Move the story behind the change (what you tried but didn't work)
after '---' and just list the actual changes in the commit description.

Testing note too?

No, that is fine.

Guenter

Testing note:
* Tested on nct6799 with IN/FAN/TEMP, and changing min/max/high/hyst,
   that triggers the corresponding alarms correctly. Good confirmation
   on the original mapping of the registers and masks.
   As to be expected, only 4 fans and 2 temps (fixed) have limits
   currently on nct6799 on my board.
* Trouble with testing intrusion alarms and beeps, no way to confirm
   those. As I understand now, intrusion/caseopen is probably not
   connected on my board.
   And I haven't seen a buzzer on a board in ages.





[Index of Archives]     [LM Sensors]     [Linux Sound]     [ALSA Users]     [ALSA Devel]     [Linux Audio Users]     [Linux Media]     [Kernel]     [Gimp]     [Yosemite News]     [Linux Media]

  Powered by Linux