Hello Guenter and Greg: > > Again, as in patch 2/3, you forgot a signed-off-by line. Will resubmit with proper Sign-off > > You are creating a fake platform device out of no where here, which is > > tied to nothing, which isn't ok. Keep it in the proper device tree and > > have it be passed to you by the driver core in the probe() function. > > > > This is a system with dmi data, so it won't support devicetree. Other > than that, you are correct, this patch is definitely not a good idea > and needs to be dropped. > > Thanks, > Guenter > > > I think you will see that this changed where in /sys/devices/ your > > device is now, right? The attribute is created in the same place as before this patch. And works the same as before this patch. I can drop this patch and only resubmit 1 and 2. Thanks for the review to both of you. -- Joaquín I. Aramendía
