Re: [PATCH v2 1/2] dt-bindings: hwmon: Add description for new hwmon driver hs3001

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 7/16/23 09:33, Krzysztof Kozlowski wrote:
On 16/07/2023 17:05, Andre Werner wrote:
This is the initial description.

Signed-off-by: Andre Werner <andre.werner@xxxxxxxxxxxxxxxxxxxxx>

Duplicated patch, but my comments stay - you did not CC people I asked for.

---
  Documentation/devicetree/bindings/trivial-devices.yaml | 2 ++
  1 file changed, 2 insertions(+)

diff --git a/Documentation/devicetree/bindings/trivial-devices.yaml b/Documentation/devicetree/bindings/trivial-devices.yaml
index ba2bfb547909..5a5de3f6cd37 100644
--- a/Documentation/devicetree/bindings/trivial-devices.yaml
+++ b/Documentation/devicetree/bindings/trivial-devices.yaml
@@ -320,6 +320,8 @@ properties:
              # Rohm DH2228FV
            - rohm,dh2228fv
              # S524AD0XF1 (128K/256K-bit Serial EEPROM for Low Power)
+          - renesas,hs3001
+            # Renesas HS300[1,2,3,4] Temperature and Relative Humidity Sensors

wrong comment.


Maybe clarify that the comment comes first, i.e., that it should be

+            # Renesas HS300[1,2,3,4] Temperature and Relative Humidity Sensors
+          - renesas,hs3001

and that it should be added before renesas,isl29501 to retain alphabetic order.

Guenter

            - samsung,24ad0xd1

Samsung, not Renesas


Best regards,
Krzysztof





[Index of Archives]     [LM Sensors]     [Linux Sound]     [ALSA Users]     [ALSA Devel]     [Linux Audio Users]     [Linux Media]     [Kernel]     [Gimp]     [Yosemite News]     [Linux Media]

  Powered by Linux