Re: [PATCH] hwmon: (nct6775) Change labels for nct6799

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 7/15/23 09:39, Ahmad Khalifa wrote:
On 15/07/2023 17:09, Guenter Roeck wrote:
On 7/15/23 08:29, Ahmad Khalifa wrote:
   * #temp lists the number of monitored temperature sources (first value) plus
   * the number of directly connectable temperature sensors (second value).
+ *
+ * (*) nct6799d-r based on nct6796d-s and both quite different to nct6796d

We should not say "based on" without evidence (that is, someone from Nuvoton confirming
that this is the case), and "both quite different to nct6796d" is just confusing.
nct6799d is _expected_ to be different to nct6796d. This should say something like
"nct6796d-s is similar to nct6799d-r with minor differences which do not affect the
driver".

It was Nuvoton support that told me that NCT6799D-R was a customer-
specific chip, but "very similar" to 6796d-S.

The point here was to specify the relevant chip ids and to say that the
driver treats both the same way, so I can rephrase it to say "driver
treats both the same way" maybe?


It should say that the two chips are similar and that the driver does not
treat them differently. I'll leave the exact wording to you.

However, I'm somewhat sure the temperature sources on 6799d-R use one of
the reserved values when setup through the bios.

Apparently there are also NCT6796D-E (Nuvoton's web site) and NCT6796D-R
(LibreHardwareMonitor). Do you know anything about those chips ? Based on the
chip ID, NCT6796-R seems to be a variant of NCT6798D with chip ID 0xd42a.

Do you know which board had the NCT6796-R, it seems the R suffix is
"customer-specific"?


From LibreHardwareMonitor commit log:

Add initial NCT6796D-R support

    This is used by Asrock X570 Pro4

Any chance you can share the datasheet for NCT6796D-S ?

Of course:
https://khalifa.ws/randomfiles/nuvoton/NCT6796D-S_Datasheet_V0_6.pdf

Thanks!

Guenter




[Index of Archives]     [LM Sensors]     [Linux Sound]     [ALSA Users]     [ALSA Devel]     [Linux Audio Users]     [Linux Media]     [Kernel]     [Gimp]     [Yosemite News]     [Linux Media]

  Powered by Linux