On Tue, Jul 04, 2023 at 06:39:07AM -0700, Guenter Roeck wrote: > On 7/4/23 06:17, Greg Kroah-Hartman wrote: > > Drivers should not have a single static variable for the type of device > > they are bound to. While this driver is really going to only have one > > device at a time in the system, remove the static variable and instead, > > look up the device type when needed. > > > > This is expensive. I think it would be much better to just move > the board type detection into the init code and not instantiate > the driver in the fist place if the board type is unknown. The board type detection is all over the place in the driver, it's not just for "unknown" types, so how about just saving the board type at probe time and using it then for all other places? > We can handle the static variable separately if it really bothers > you that much. I did this change to make patch 2/3 more "obvious" what is happening when the in_visible() callback happens, so that you don't have to worry about the saved value or not. But this whole patch isn't really needed if you don't mind the lookup just happening in the in_visible() callback for the first time. thanks, greg k-h
