Re: [PATCH] hwmon: (pmbus) Update documentation to not use .probe_new() any more

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Uwe,

On 6/26/23 23:49, Uwe Kleine-König wrote:
Since commit 03c835f498b5 ("i2c: Switch .probe() to not take an id
parameter") .probe() is the recommended callback to implement an i2c
driver (again). Reflect this in the documentation and don't mention
.probe_new() which will be dropped soon.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx>
---
Hello,

this patch was part of a patch dropping .probe_new() before (see
https://lore.kernel.org/linux-i2c/20230626094548.559542-1-u.kleine-koenig@xxxxxxxxxxxxxx).

However this change makes already sense without dropping .probe_new, so
here it comes as a separate patch.

Best regards
Uwe


I got this after sending my pull request, and I don't currently plan to send
another one. What is the time line for the probe_new removal ? If it is
still planned for 6.5, you might want to keep it as part of the series.
In that case,

Acked-by: Guenter Roeck <linux@xxxxxxxxxxxx>

Thanks,
Guenter

  Documentation/hwmon/pmbus.rst | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Documentation/hwmon/pmbus.rst b/Documentation/hwmon/pmbus.rst
index 7ecfec6ca2db..eb1569bfa676 100644
--- a/Documentation/hwmon/pmbus.rst
+++ b/Documentation/hwmon/pmbus.rst
@@ -163,7 +163,7 @@ Emerson DS1200 power modules might look as follows::
  	.driver = {
  		   .name = "ds1200",
  		   },
-	.probe_new = ds1200_probe,
+	.probe = ds1200_probe,
  	.id_table = ds1200_id,
    };
base-commit: 6995e2de6891c724bfeb2db33d7b87775f913ad1




[Index of Archives]     [LM Sensors]     [Linux Sound]     [ALSA Users]     [ALSA Devel]     [Linux Audio Users]     [Linux Media]     [Kernel]     [Gimp]     [Yosemite News]     [Linux Media]

  Powered by Linux