On 26/06/2023 09:29, JuenKit_Yip@xxxxxxxxxxx wrote: > From: JuenKit Yip <JuenKit_Yip@xxxxxxxxxxx> > > add sht3x devicetree binding files > > Signed-off-by: JuenKit Yip <JuenKit_Yip@xxxxxxxxxxx> > --- > v1: > - fix semantics error How first release can have already fixes? Against what? Is it truly v1? What is a "semantics error"? A nit, subject: drop second/last, redundant "devicetree binding". The "dt-bindings" prefix is already stating that these are bindings. > > .../bindings/hwmon/sensirion,sht3x.yaml | 35 +++++++++++++++++++ > 1 file changed, 35 insertions(+) > create mode 100644 Documentation/devicetree/bindings/hwmon/sensirion,sht3x.yaml > > diff --git a/Documentation/devicetree/bindings/hwmon/sensirion,sht3x.yaml b/Documentation/devicetree/bindings/hwmon/sensirion,sht3x.yaml > new file mode 100644 > index 000000000000..71a50bd57af2 > --- /dev/null > +++ b/Documentation/devicetree/bindings/hwmon/sensirion,sht3x.yaml > @@ -0,0 +1,35 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/hwmon/sensirion,sht3x.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Sensirion SHT3x-DIS humidity and temperature sensor > + > +maintainers: > + - JuenKit Yip <JuenKit_Yip@xxxxxxxxxxx> > + > +properties: > + compatible: > + enum: > + - sensirion,sht3x The actual devices are SHT30, 31 and 35. I understand they don't differ in programming interface, but still don't use wildcard, so just sensirion,sht30 > + - sensirion,sts3x Similarly - no wildcards. Missing blank line. > + reg: > + maxItems: 1 Missing vdd-supply (required) and reset-gpios (optional). > + > +required: > + - compatible > + - reg > + > +additionalProperties: false > + Best regards, Krzysztof
