On 6/10/23 14:05, Kannan, Baski wrote:
[AMD Official Use Only - General]
Hmm.. Somehow the commit message was not included in the signoff email.
Checking now.
Sorry for the spam.
That is not the only change you were asked to make. Commit description, version,
change log, unnecessary (), direct use of boolean instead of comparing it
against false, unnecessary {}, missing space between ( and { is just what
comes into mind immediately.
Oh, and also:
The subject needs to be "hwmon: (k10temp) Enable AMD3255 Processor to show
negative temperature" or similar.
Guenter
-----Original Message-----
From: Guenter Roeck <groeck7@xxxxxxxxx> On Behalf Of Guenter Roeck
Sent: Saturday, June 10, 2023 3:59 PM
To: Kannan, Baski <Baski.Kannan@xxxxxxx>; Limonciello, Mario <Mario.Limonciello@xxxxxxx>; Moger, Babu <Babu.Moger@xxxxxxx>; clemens@xxxxxxxxxx; jdelvare@xxxxxxxx; linux-hwmon@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx
Cc: Kannan, Baski <Baski.Kannan@xxxxxxx>
Subject: Re: [PATCH] Enable AMD3255 Proc to show negative temperature
Caution: This message originated from an External Source. Use proper caution when opening attachments, clicking links, or responding.
On 6/10/23 13:53, Baskaran Kannan wrote:
From: Baskaran Kannan <bakannan@xxxxxxx>
Signed-off-by: Baskaran Kannan <Baski.Kannan@xxxxxxx>
Please resubmit and either make the changes you were asked to make, or explain why you did not follow them.
Guenter
