Hi--
Style issues:
On 6/9/23 16:11, Baskaran Kannan wrote:
> From: Your Name <you@xxxxxxxxxxx>
Fix that. ^^^^^
Provide a comment message (not empty).
>
> Signed-off-by: Baski Kannan <Baski.Kannan@xxxxxxx>
> ---
> drivers/hwmon/k10temp.c | 17 +++++++++++++++++
> 1 file changed, 17 insertions(+)
>
> diff --git a/drivers/hwmon/k10temp.c b/drivers/hwmon/k10temp.c
> index 489ad0b1bc74..58e4d90de5e3 100644
> --- a/drivers/hwmon/k10temp.c
> +++ b/drivers/hwmon/k10temp.c
> @@ -77,6 +77,11 @@ static DEFINE_MUTEX(nb_smu_ind_mutex);
> #define ZEN_CUR_TEMP_RANGE_SEL_MASK BIT(19)
> #define ZEN_CUR_TEMP_TJ_SEL_MASK GENMASK(17, 16)
>
> +/* AMD's Industrial processor 3255 supports temperature from -40 deg to 105 deg Celsius.
> + * Do not round off to zero for negative Tctl or Tdie values
> + */
Linux multi-line coding style (except for net/ and bpf/) is like:
/*
* AMD's Industrial processor 3255 supports temperature from -40 deg to 105 deg Celsius.
* Do not round off to zero for negative Tctl or Tdie values
*/
End the last sentence above with a period.
> +#define AMD_I3255_STR "3255"
> +
> struct k10temp_data {
> struct pci_dev *pdev;
> void (*read_htcreg)(struct pci_dev *pdev, u32 *regval);
For the next patch version, please make sure that it says v2
and explain the differences in v1 and v2.
thanks.
--
~Randy
