On 08/06/2023 09:47, Billy Tsai wrote: > > >> + > >> +allOf: > >> + - $ref: pwm.yaml# > >> + > >> +properties: > >> + compatible: > >> + enum: > >> + - aspeed,ast2600-pwm > >> + > >> + "#pwm-cells": > >> + const: 3 > > > 3 cells? For one PWM? What are they? > > channel, period and polarity. Don't cut my responses. You wrote you have one PWM output, so only one channel. What do you put then in the channel? I will start NAKing such patches without DTS user. It's like reviewing fake code for some unknown solution and trying to get from you piece of answers one by one, because you do not want to share entire part. Best regards, Krzysztof