On 08/06/2023 04:18, Billy Tsai wrote: > Unlike the old design that the register setting of the TACH should based > on the configure of the PWM. In ast26xx, the dependency between pwm and > tach controller is eliminated and becomes a separate hardware block. One > is used to provide pwm output and another is used to monitor the frequency > of the input. Therefore, this patch serials implements them by writing the > two driver "pwm-aspeed-ast2600.c" and "tach-aspeed-ast2600.c". The former > is following the pwm subsystem which can apply the existed driver to > controller the fan(pwm-fan.c), beeper(pwm-beeper.c) and so on. The latter > is following the sysfs interface of hwmon to creat the node for fan > monitor. You like to ignore my comments... How did you implement them? Go one by one - answer to v4 emails. Best regards, Krzysztof
