> You need to better organize your changes and split some refactorings > from new devices. I don't understand why eff0000 becomes 4eff0000 - > whether this is a bug being fixed, incorrect design etc. Commit msg just > says "to be correct", so this is was a bug. Bugfixes cannot mixed with > new features/code/refactorings. Anyway this is very vague. Explain what > is not correct, why it has to be fixed. Thank you for all of the feedback you have provided Krzysztof, It indeed is a bug that was introduced early on. I attempted previously to correct this issue separately here: https://lore.kernel.org/all/20230130220056.14349-2-nick.hawkins@xxxxxxx/ I see though that I have made some of the mistakes you mentioned above. I will resubmit. > > + gpio: gpio@0 { > > + compatible = "hpe,gxp-gpio"; > > + reg = <0x0 0x400>, <0x200046 0x1>, <0x200070 0x08>, > > + <0x400064 0x80>, <0x5100030f 0x1>; > This looks randomly indented... Although the design is likely to change I will use a format similar to gpio-line-names you mentioned previously. Thanks, -Nick Hawkins
