On Mon, Apr 10, 2023 at 06:48:12PM +0200, Krzysztof Kozlowski wrote: > On 10/04/2023 16:03, Guenter Roeck wrote: > > On 4/10/23 02:56, Michael S. Tsirkin wrote: > >> On Fri, Apr 07, 2023 at 04:08:30PM -0700, Guenter Roeck wrote: > >>> On 4/7/23 08:01, Krzysztof Kozlowski wrote: > >>>> Statically allocated array of pointed to hwmon_channel_info can be made > >>>> const for safety. > >>>> > >>>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx> > >>>> > >>>> --- > >>>> > >>>> This depends on hwmon core patch: > >>>> https://lore.kernel.org/all/20230406203103.3011503-2-krzysztof.kozlowski@xxxxxxxxxx/ > >>>> > >>>> Therefore I propose this should also go via hwmon tree. > >>> > >>> I am not going to apply patches for 10+ subsystems through the hwmon tree. > >>> This can only result in chaos. The dependent patch is available at > >>> > >>> git://git.kernel.org/pub/scm/linux/kernel/git/groeck/linux-staging.git hwmon-const > >> > >> Doesn't it cause build errors or warnings there? > >> > > > > Are you saying that "hwmon: constify pointers to hwmon_channel_info" applied on its own > > on top of v6.3-rc5 (as done in above branch) causes build errors or warnings ? > > I have not seen any such reports, and I don't immediately see why that would be > > the case. Please elaborate. > > My tree and patches are extensively tested by kbuild and there was no > warning reported (when the above patch is applied with above dependency). > > Best regards, > Krzysztof I don't know, I assumed the vdpa patch fixes build. If not, I think we can just wait with the vdpa patch until after the hwmon one is upstream. Thanks! -- MST
